Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace NaN values in deduped TA table #1211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

2 things:

  • moving dedup from the test_analytics resolver to get_results
  • changing dedup to fill_nan values with 0

@joseph-sentry joseph-sentry requested a review from a team as a code owner March 13, 2025 17:26
Copy link
Contributor

sentry-autofix bot commented Mar 13, 2025

🚨 Sentry detected 10 potential issues in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (8d9cd04) to head (d6d5163).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         493      493           
  Lines       16880    16883    +3     
=======================================
+ Hits        16183    16186    +3     
  Misses        697      697           
Flag Coverage Δ
unit 95.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant