Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to search_files_by_name tool #886

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

codegen-sh[bot]
Copy link
Contributor

@codegen-sh codegen-sh bot commented Mar 18, 2025

This PR adds pagination support to the search_files_by_name tool, similar to how it's implemented in the search tool. This addresses the issue where large result sets from file searches were causing long, unwieldy output.

Changes:

  • Updated SearchFilesByNameResultObservation class to include pagination parameters (page, total_pages, total_files, files_per_page)
  • Added a custom render() method to format the output with pagination information
  • Modified the search_files_by_name function to support pagination with parameters for page number and files per page
  • Updated the SearchFilesByNameInput class and SearchFilesByNameTool._run() method to accept and pass through pagination parameters
  • Set default files_per_page to 50 (higher than search tool's default of 10 since filenames are shorter)
  • Added sorting of results for consistent pagination

This change will make the tool more usable when dealing with large codebases that have many matching files.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant