Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of codecov ATS feature #887

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Swatinem
Copy link

We are in the process of deprecating the ATS feature of codecov, and I saw you are one of the few (open source) users of it.

This PR removes the usage of ATS, just calling out to the whole testsuite all at once. I did keep some of the --collect logic for the codemod-tests CI job, as I believe this is doing some kind of testsuite splitting.

As I saw you have modified the CI related workflows fairly recently, I’m curious whether the ATS feature as it exists is providing any value to you?


A completely unrelated comment, as I have looked at your other CI jobs as well, you are limiting mypy checks to only the changed files. However any changes to types can also have an effect on downstream importers, which also need to be typechecked. As those are skipped by the filtering to only changed files, this can cause type errors in subsequent PRs.

We are in the process of deprecating the ATS feature of codecov, and I saw you are one of the few (open source) users of it.

This PR removes the usage of ATS, just calling out to the whole testsuite all at once.
I did keep some of the `--collect` logic for the `codemod-tests` CI job, as I believe this is doing some kind of testsuite splitting.

As I saw you have modified the CI related workflows fairly recently, I’m curious whether the ATS feature as it exists is providing any value to you?
@Swatinem Swatinem requested review from codegen-team and a team as code owners March 18, 2025 10:33
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants