Remove usage of codecov ATS feature #887
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of deprecating the ATS feature of codecov, and I saw you are one of the few (open source) users of it.
This PR removes the usage of ATS, just calling out to the whole testsuite all at once. I did keep some of the
--collect
logic for thecodemod-tests
CI job, as I believe this is doing some kind of testsuite splitting.As I saw you have modified the CI related workflows fairly recently, I’m curious whether the ATS feature as it exists is providing any value to you?
A completely unrelated comment, as I have looked at your other CI jobs as well, you are limiting
mypy
checks to only the changed files. However any changes to types can also have an effect on downstream importers, which also need to be typechecked. As those are skipped by the filtering to only changed files, this can cause type errors in subsequent PRs.