Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with summarization Error for images #910

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

tawsifkamal
Copy link
Contributor

No description provided.

@tawsifkamal tawsifkamal requested review from codegen-team and a team as code owners March 19, 2025 21:09
Copy link
Contributor

@jemeza-codegen jemeza-codegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

# Choose template based on whether we have images
summarizer_content = [{"type": "text", "text": SUMMARIZE_CONVERSATION_PROMPT}]
for image_url in image_urls:
summarizer_content.append(image_url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to summarize the images?

@tawsifkamal tawsifkamal enabled auto-merge (squash) March 19, 2025 23:57
@tawsifkamal tawsifkamal disabled auto-merge March 20, 2025 00:12
@tawsifkamal tawsifkamal merged commit 53e774d into develop Mar 20, 2025
17 of 18 checks passed
@tawsifkamal tawsifkamal deleted the tawsif/summarization-image-stuff branch March 20, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants