Fix search_files_by_name to properly handle glob patterns with ** #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the
search_files_by_name
tool where it wasn't properly handling glob patterns that include**
(recursive directory matching), such as**/.github/workflows/*.yml
.Changes
**
for bothfd
andfind
commands**/
find
, using-path
instead of-name
when the pattern contains**
fd
, added the-t f
flag to ensure we're only finding files**/.github/workflows/*.yml
Testing
This change should allow patterns like
**/.github/workflows/*.yml
to correctly find GitHub workflow files at any directory depth.Fixes the issue reported in Slack where
search_files_by_name
wasn't finding GitHub workflow files with the pattern**/.github/workflows/*.yml
.