CG-10705: API to remove async from functions

src/codegen/sdk/core/function.py

@@ -33,7 +33,6 @@
     from codegen.sdk.core.statements.return_statement import ReturnStatement
     from codegen.sdk.core.symbol import Symbol
 
-
 TDecorator = TypeVar("TDecorator", bound="Decorator", default=Decorator)
 TCodeBlock = TypeVar("TCodeBlock", bound="CodeBlock", default=CodeBlock)
 TParameter = TypeVar("TParameter", bound="Parameter", default=Parameter)
@@ -41,7 +40,7 @@
 
 
 @apidoc
 class Function(
     SupportsGenerics[TType],
     HasBlock[TCodeBlock, TDecorator],
     Callable[TParameter, TType],
@@ -126,7 +125,7 @@
         Returns:
             bool: True if the function is a constructor method of a class, False otherwise.
         """
         return self.is_method and self.name == self.parent_class.constructor_keyword
 
     @property
     def is_async(self) -> bool:
@@ -146,35 +145,15 @@
 
         for symbol in self.valid_symbol_names:
             if symbol.name == name and (start_byte is None or (symbol.start_byte if isinstance(symbol, Class | Function) else symbol.end_byte) <= start_byte):
                 yield symbol
                 return
         yield from super().resolve_name(name, start_byte, strict=strict)
 
     @cached_property
     @noapidoc
     def valid_symbol_names(self) -> list[Importable]:
         return sort_editables(self.parameters.symbols + self.descendant_symbols, reverse=True)
 
-    # Faster implementation which uses more memory
-    # @noapidoc
-    # @reader
-    # def resolve_name(self, name: str, start_byte: int | None = None) -> Symbol | Import | WildcardImport | None:
-    #     if symbols := self.valid_symbol_names.get(name, None):
-    #         for symbol in symbols:
-    #             from codegen.sdk.core.class_definition import Class
-    #
-    #             if (symbol.start_byte if isinstance(symbol, Class | Function) else symbol.end_byte) <= start_byte:
-    #                 return symbol
-    #     return super().resolve_name(name, start_byte)
-    #
-    # @cached_property
-    # @noapidoc
-    # def valid_symbol_names(self) -> dict[str, list[Importable]]:
-    #     ret = defaultdict(list)
-    #     for elem in sort_editables(self.parameters.symbols + self.descendant_symbols, reverse=True):
-    #         ret[elem.name].append(elem)
-    #     return ret
-    #
     ###########################################################################################################
     # PROPERTIES
     ###########################################################################################################
@@ -207,7 +186,7 @@
         Returns:
             list[ReturnStatement]: A list of all return statements found within the function's body.
         """
         return self.code_block.get_statements(statement_type=StatementType.RETURN_STATEMENT)
 
     @property
     @reader
@@ -219,7 +198,7 @@
         Returns:
             list[Self]: A list of Function objects representing nested functions within this function's body, sorted by position in the file.
         """
         functions = [m.symbol for m in self.code_block.symbol_statements if isinstance(m.symbol, self.__class__)]
         return functions
 
     ####################################################################################################################
@@ -262,6 +241,33 @@
 
         self.add_keyword("async")
 
+    @writer
+    def remove_async(self) -> None:
+        """Removes the async keyword from a function.
+
+        Converts an asynchronous function to be synchronous by removing the 'async' keyword from its definition.
+        This method has no effect if the function is not asynchronous.
+
+        Returns:
+            None
+
+        Note:
+            This method has no effect if the function is not asynchronous.
+        """
+        if not self.is_async:
+            return
+
+        # Find the async keyword node
+        for node in self.children_by_field_types(self.ctx.node_classes.keywords):
+            if node == "async":
+                # Remove the async keyword and any following whitespace
+                node_source = node.source
+                if node_source.endswith(" "):
+                    node.edit("")
+                else:
+                    node.edit("", newline=False)
+                return
+
     @writer
     def rename_local_variable(self, old_var_name: str, new_var_name: str, fuzzy_match: bool = False) -> None:
         """Renames a local variable and all its usages within a function body.
@@ -276,7 +282,7 @@
         Returns:
             None: The method modifies the AST in place.
         """
         matches = self.code_block.get_assignments(old_var_name, fuzzy=fuzzy_match, parameters=False)
         for match in matches:
             new_name = new_var_name
             if fuzzy_match:
@@ -302,7 +308,7 @@
         if index == 0:
             return self.prepend_statements(lines)
 
         statements = self.code_block.statements
         if index >= len(statements):
             msg = f"Index {index} out of range for function {self.name}"
             raise ValueError(msg)