Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reg updates #114

Merged
merged 17 commits into from
Sep 27, 2021
Merged

Reg updates #114

merged 17 commits into from
Sep 27, 2021

Conversation

coder137
Copy link
Owner

  • Added Register::Dep updates
    • Detect duplicate deps (immediate)
    • Detect cyclic dependency (complete/nested)
  • Added RegInfo pairing
  • [Fix] Register::Dep causes crash when state.build == false during Register::Build
    • This happens when multiple toolchains are added but only few targets are built
  • [Fix] Change store detection to GetBinaryPath from GetTargetPath

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #114 (52cfbcb) into main (088eb2f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   98.92%   98.95%   +0.03%     
==========================================
  Files          29       29              
  Lines         834      861      +27     
  Branches      271      281      +10     
==========================================
+ Hits          825      852      +27     
  Partials        9        9              
Impacted Files Coverage Δ
buildcc/lib/args/include/args/register.h 100.00% <100.00%> (ø)
buildcc/lib/args/src/register.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088eb2f...52cfbcb. Read the comment docs.

@coder137 coder137 merged commit 649e924 into main Sep 27, 2021
@coder137 coder137 deleted the reg_updates branch September 27, 2021 06:25
@coder137 coder137 mentioned this pull request Oct 4, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant