Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functionality] Reduce Custom generator scope to a Single stage generator #227

Merged
merged 19 commits into from
Nov 24, 2022

Conversation

coder137
Copy link
Owner

Reduces the scope of Custom Generator functionality to remain a Single-Stage generator.

Earlier implementation of Custom Generator was very complex and allowed it to be a Multi-Stage generator.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 99.31% // Head: 99.15% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (03061bd) compared to base (57a26a5).
Patch coverage: 98.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   99.31%   99.15%   -0.16%     
==========================================
  Files          73       75       +2     
  Lines        2039     2004      -35     
  Branches      573      564       -9     
==========================================
- Hits         2025     1987      -38     
- Partials       14       17       +3     
Impacted Files Coverage Δ
buildcc/lib/target/include/target/file_generator.h 100.00% <ø> (ø)
...dcc/lib/target/include/target/template_generator.h 100.00% <ø> (ø)
...cc/schema/include/schema/custom_generator_schema.h 100.00% <ø> (ø)
...ildcc/lib/target/include/target/custom_generator.h 98.28% <97.67%> (-1.72%) ⬇️
...lude/target/custom_generator/custom_blob_handler.h 100.00% <100.00%> (ø)
...target/custom_generator/custom_generator_context.h 100.00% <100.00%> (ø)
...b/target/src/custom_generator/custom_generator.cpp 98.94% <100.00%> (-0.43%) ⬇️
...ldcc/schema/src/custom_generator_serialization.cpp 94.44% <0.00%> (-5.56%) ⬇️
buildcc/schema/src/target_serialization.cpp 96.97% <0.00%> (-3.03%) ⬇️
buildcc/lib/target/src/target/build.cpp 91.43% <0.00%> (-0.68%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coder137 coder137 merged commit 59f43d5 into main Nov 24, 2022
@coder137 coder137 deleted the custom_generator_improvements branch November 24, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant