Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: popover opening direction #2022

Merged
merged 4 commits into from
Apr 17, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'feat/vertical-toolbox' into fix/popover-open-direction
TatianaFomina committed Apr 17, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4599b61a75903ed839466f02b345125bea12e56a
7 changes: 7 additions & 0 deletions src/components/ui/toolbox.ts
Original file line number Diff line number Diff line change
@@ -248,6 +248,13 @@ export default class Toolbox extends EventsDispatcher<ToolboxEvent> {
return popoverPotentialTopEdge < editorElementRect.top || popoverPotentialBottomEdge <= bottomEdgeForComparison;
}

/**
* Handles overlay click
*/
private onOverlayClicked = (): void => {
this.close();
}

/**
* Returns list of tools that enables the Toolbox (by specifying the 'toolbox' getter)
*/
2 changes: 1 addition & 1 deletion src/components/utils/popover.ts
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ import Listeners from './listeners';
import Flipper from '../flipper';
import SearchInput from './search-input';
import EventsDispatcher from './events';
import { isMobile, keyCodes, cacheable } from '../utils';
import { isMobileScreen, keyCodes, cacheable } from '../utils';

/**
* Describe parameters for rendering the single item of Popover
You are viewing a condensed version of this merge commit. You can view the full changes here.