[Fix] Stop jumping to block start on toolbox close #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaFomina
requested review from
neSpecc,
gohabereg and
ilyamore88
as code owners
TatianaFomina
commented
May 9, 2022
| @@ -167,7 +167,6 @@ export default class Toolbar extends Module<ToolbarNodes> { | |||
| opened: this.toolboxInstance.opened, | |||
| close: (): void => { | |||
| this.toolboxInstance.close(); | |||
| this.Editor.Caret.setToBlock(this.Editor.BlockManager.currentBlock); | |||
There was a problem hiding this comment.
@neSpecc
didn't get why this line is needed, so removed it. If it is needed, it can be executed on condition or moved to some other place
There was a problem hiding this comment.
Try this:
- Place the caret to the empty block
- Press Tab to open the Toolbox
- Press Esc to close the Toolbox
The Caret should return to the empty block. In case of removing this line that wouldn't happenn.
There was a problem hiding this comment.
Ok, moved this line to function called on esc press
neSpecc
approved these changes
May 12, 2022
gohabereg
approved these changes
May 12, 2022
ilyamore88
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with text selection from right to left. Moving caret to block start on toolbox close was causing the problem.
Resolves #2045