DDF-2116: NPM related build errors in Bamboo #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@lessarderic can you summarize how the version upgrades resolve the build issues? |
|
@shaundmorris, I just added a blurb in the PR description. Hopefully it addresses your comment. If not, let me know. |
|
thanks @lessarderic sounds good! |
|
when this works do we need to put up a PR for 2.9.x as well? |
|
Bamboo build was successful but marked as failed because Bamboo ran out of memory parsing all of our surefire test result files (known issue). @kcwire, I'll port this change to 2.9.x. Merging. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update NPM and NodeJS versions to address build issues in Bamboo.
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?
@coyotesqrl @ahoffer
Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).
@pklinef
@shaundmorris
How should this be tested?
Build DDF
Any background context you want to provide?
The problem is caused by older versions of nodejs (<= 4.2.x) that fail on idle connections (see nodejs/node#3595). Upgrading to a more recent version of nodejs that fixes issue #3595 addresses this issue.
What are the relevant tickets?
DDF-2116
Screenshots (if appropriate)
Checklist: