Moderator Tool Improvements #767

luap42 · 2022-02-05T21:39:49Z

Some improvements to the moderator tools.
(Documentation comes soon)

app/assets/javascripts/application.js

app/controllers/application_controller.rb

app/controllers/comments_controller.rb

app/views/mod_warning/new.html.erb

ArtOfCode- · 2022-04-12T15:03:10Z

app/views/users/mod_delete.html.erb

+        <div class="widget--body">
+            <h4>Destroy Acccount</h4>
+            <p>Destroy Accounts of blatant spammers and trolls.</p>
+
+            <%= link_to 'Destroy Account', destroy_user_path(@user.id), remote: true,
+                        method: :delete, class: 'js-destroy-user button is-danger is-filled' %>
+        </div>


discuss: We should review whether we actually want this here. Destroying accounts completely is a good way to break the database, and now that we have soft-deletes it's probably not needed.

I propose to remove "destroy" for the reasons Art said.

@trichoplax if the destroy option is still there, could you remove it from the UI at least? Thanks.

It appears that the destroy button is not new, just moved from a different place in the existing user interface. There are 4 similarly named buttons that appear together in the existing user interface, but have been separated in the new user interface.

Existing delete and destroy buttons

New Delete or Destroy Account section

New Hungry Codidactyl (Delete, Feed to STAT) section

Some questions:

Which of the 4 buttons are to be removed and which are to remain?

I'm assuming we remove "Destroy Account" (currently called "Destroy user") and keep "Delete community profile", "Delete user network-wide", and "Feed to STAT (180 days)".

Should the remaining buttons be relocated?

I'm assuming "Delete community profile" will stay in a section of its own, since the other 2 buttons are only available to global moderators (the section could be renamed from "Delete or Destroy Account" to just "Delete Account")

The section name "Hungry Codidactyl (Delete, Feed to STAT)" seems incompatible with non-Codidact instances. It could instead be "Delete Network Account", and just contain 1 button, "Delete user network-wide". The button "Feed to STAT (180 days)" seems more similar to a suspension than a deletion, so perhaps it could be moved to the section "Network-wide Suspension".

Yes, remove the "Destroy Account" button and keep the other three.

I defer to @luap42 but I think this is right.

I defer to luap42 again but yeah, that sounds better for a public platform rather than our own instance. I believe "feed to STAT" is delete+ spam-block.

trichoplax · 2023-02-02T00:26:53Z

Would it be practical to split this pull request into smaller changes to allow some to be deployed and get real world feedback?

I'm wondering because of the issues that mention this pull request. Do they depend on the whole change or just smaller parts of it that might not need to wait for the rest?

cellio · 2023-02-02T01:27:25Z

@ArtOfCode- re the previous comment: do you think it would be easier to subdivide this PR or finish it? (Asking because you reviewed it in the past, so you have better insights than most other people.)

ArtOfCode- · 2023-02-02T10:13:40Z

Probably easier to finish it - would take unnecessary work to split it up. Shouldn't need much more work, though - addressing comments and requests and fixing the conflicts. @trichoplax if you find yourself looking for any more intro to Ruby, this might be doable for you.

trichoplax · 2023-02-16T00:06:48Z

@ArtOfCode- Thanks for the suggestion. I'm going to start by trying to rebase ~~master~~ develop onto this branch (in the safety of my own fork), unless anyone tells me that's a bad idea (this will be my first rebase).

New dependencies require ruby 2.7 and rails 6.0 as minimum versions.

It seems that the update to rubocop/rails means we get some new rules. The new rules seem to have changed their minds on how some things should look or be done. This applies the new rules.

Also swap arguments around such that the error message upon failure lists the right value as expected.

Also add a note in the INSTALLATION about the ruby versions that are supported/not supported.

The only setting left in new_framework_defaults_6.0 is about updating the cookies. If the system runs stable on rails 6, the file can be removed and the upgrade is completed.

Rails 6.1 is more picky about the response formats, and not having the intended html extension can cause issues.

cellio · 2024-12-05T18:05:16Z

I was going to update this from develop but apparently there are conflicts now, so that'll require some human attention.

cellio · 2025-02-11T22:05:41Z

We're starting to add some other small improvements for mods, and I don't want to conflict with work here that's coming, but also this PR is old and I don't think @luap42 wrote that documentation mentioned in the description and I've lost track of what's here. What's the easiest way to get an overview of what's here?

codecov · 2025-03-01T18:23:26Z

Codecov Report

Attention: Patch coverage is 38.21656% with 97 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (cb332b0) to head (fae0628).

Files with missing lines	Patch %	Lines
app/controllers/users_controller.rb	20.89%	53 Missing ⚠️
app/controllers/mod_warning_controller.rb	16.66%	30 Missing ⚠️
app/models/user.rb	0.00%	7 Missing ⚠️
app/controllers/comments_controller.rb	88.46%	3 Missing ⚠️
app/controllers/admin_controller.rb	50.00%	1 Missing ⚠️
app/controllers/moderator_controller.rb	0.00%	1 Missing ⚠️
app/models/comment_thread.rb	88.88%	1 Missing ⚠️
app/models/mod_warning.rb	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    56.10%   55.23%   -0.87%     
===========================================
  Files          161      161              
  Lines         5379     5507     +128     
===========================================
+ Hits          3018     3042      +24     
- Misses        2361     2465     +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trichoplax · 2025-03-01T18:50:12Z

We're starting to add some other small improvements for mods, and I don't want to conflict with work here that's coming, but also this PR is old and I don't think @luap42 wrote that documentation mentioned in the description and I've lost track of what's here. What's the easiest way to get an overview of what's here?

Sorry for taking 2 and a half weeks to reply to this. I'm back now and have brought this branch up to date with changes to the develop branch. The only conflict that required a change was for the (n messages) addition to the Moderator Tools link on the user profile page. This link no longer exists in this branch, instead being replaced with an additional tab on the user page. I've therefore added the (n messages) to the title of that tab. The screenshots below show the difference. This avoids losing that change altogether, and it can be further improved later if there are any suggestions.

On develop branch:

On this branch:

Overview of changes in this branch

Mod tools tab

The "Moderator Tools: user" page is replaced with a "Moderator Tools" tab on the user page.

On develop branch:

On this branch:

Private messages

A moderator can now send a private message to a user using the comments system, without it needing to be a warning or suspension:

cellio · 2025-03-02T03:13:17Z

@trichoplax thanks very much for the screenshots and overview! And sorry for inadvertently creating that conflict on the count; I completely forgot how this was arranged on this branch. I'm really looking forward to having this on main, especially the private conversations.

trichoplax · 2025-03-02T10:31:18Z

@cellio Please don't apologise for adding useful new features. It's been great to see so much improving recently. Conflicts are a natural part of that. If there's a particular potential conflict that occurs to you when working on a new feature feel free to ask, but I'd prefer that you be able to just focus on your own changes - that's the beauty of branches. Now that I'm back I'll be glancing over other pull requests and mentioning anything that might be worth discussion while this one is being finalised.

luap42 force-pushed the luap42/moderator-tools-improvements branch from c561fbc to e61ba6f Compare April 11, 2022 17:46

ArtOfCode- requested changes Apr 12, 2022

View reviewed changes

cellio mentioned this pull request May 10, 2022

Escalated flags: add a way to respond to the moderator #793

Open

This was referenced May 18, 2022

Give mods a way to reset user name, avatar, about text (with logging) #766

Open

Mod tools: unify user annotations and warnings/suspensions pages? #749

Open

cellio mentioned this pull request Oct 14, 2022

mod tools: support some formatting in user annotations #903

Open

cellio mentioned this pull request Feb 1, 2023

Escalate can be pressed multiple times #996

Open

Taeir added 19 commits February 16, 2023 02:35

Start with migration to rails 6.0

8c4a3f8

Update schema

f3957cf

Fix warnings for case insensitive uniqueness validations

8df8b50

Enable all safe new defaults

1cba6e4

Fix deprecated where.not usage

10b184c

Fix content_type test

4ed47df

Update dependencies

caaa40b

New dependencies require ruby 2.7 and rails 6.0 as minimum versions.

Please the linter gods

07e0e9d

It seems that the update to rubocop/rails means we get some new rules. The new rules seem to have changed their minds on how some things should look or be done. This applies the new rules.

Fix docker image

ba90ab6

Update spring, only load spring in development

ee5b3df

Fix deprecation warnings for rmagick

2f6ef2a

Check media type rather than content type

cc73bd1

Also swap arguments around such that the error message upon failure lists the right value as expected.

Enable other safe defaults (not using sidekiq or resque)

e9acd15

Remove comments of safely updated packages

65a9559

Also add a note in the INSTALLATION about the ruby versions that are supported/not supported.

Update redis library to v5

e77bd6f

Switch to rails 6 defaults and cleanup safe settings

edd3a1c

The only setting left in new_framework_defaults_6.0 is about updating the cookies. If the system runs stable on rails 6, the file can be removed and the upgrade is completed.

Fix files without .html extension

6cf9a46

Rails 6.1 is more picky about the response formats, and not having the intended html extension can cause issues.

Run rails 6.1 update procedure

76bfd41

Fix rails 6 image uploading

53897ef

Reduce use of .present? for readability

40b4ce3

trichoplax mentioned this pull request Sep 5, 2024

Admin only private messages #1390

Open

trichoplax added 7 commits September 5, 2024 11:49

Adjust order and wording of Contact Privately notice

9c3f978

Draw attention to the visibility to moderators of a private message

6e781b8

Allow moderators (and implicitly admins) to view all private messages

8543bc7

Merge branch 'develop' into luap42/moderator-tools-improvements

2ff6fa3

Merge branch 'develop' into luap42/moderator-tools-improvements

0b2ad8c

Allow notifications on a thread without a parent post

864c420

Show username at top of private thread to avoid confusion

d7b6b9d

cellio mentioned this pull request Sep 19, 2024

Add mod-private info to network profile #1410

Open

trichoplax and others added 9 commits September 27, 2024 00:41

Merge branch 'develop' into luap42/moderator-tools-improvements

033c662

Merge branch 'develop' into luap42/moderator-tools-improvements

e1a5220

Merge branch 'develop' into luap42/moderator-tools-improvements

61fadf6

Merge branch 'develop' into luap42/moderator-tools-improvements

441d2ff

Merge branch 'develop' into luap42/moderator-tools-improvements

c988e28

Merge branch 'develop' into luap42/moderator-tools-improvements

71f62b7

Merge branch 'develop' into luap42/moderator-tools-improvements

a5ab018

Merge branch 'develop' into luap42/moderator-tools-improvements

5f32ee5

rubocop fix

4f9147d

trichoplax added 3 commits January 10, 2025 17:34

Merge branch 'develop' into luap42/moderator-tools-improvements

5302aee

Merge branch 'develop' into luap42/moderator-tools-improvements

525f6e8

Merge branch 'develop' into luap42/moderator-tools-improvements

5fd65d3

Merge branch 'develop' into luap42/moderator-tools-improvements

fae0628

trichoplax mentioned this pull request Mar 3, 2025

Remove special case notifying author of threads #1037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moderator Tool Improvements #767

Moderator Tool Improvements #767

luap42 commented Feb 5, 2022

ArtOfCode- Apr 12, 2022

cellio Dec 28, 2022

cellio Aug 14, 2023

trichoplax Aug 18, 2023

cellio Aug 18, 2023

trichoplax commented Feb 2, 2023

cellio commented Feb 2, 2023

ArtOfCode- commented Feb 2, 2023

trichoplax commented Feb 16, 2023 •

edited

Loading

cellio commented Dec 5, 2024

cellio commented Feb 11, 2025

codecov bot commented Mar 1, 2025

trichoplax commented Mar 1, 2025

cellio commented Mar 2, 2025

trichoplax commented Mar 2, 2025

Moderator Tool Improvements #767

Are you sure you want to change the base?

Moderator Tool Improvements #767

Conversation

luap42 commented Feb 5, 2022

ArtOfCode- Apr 12, 2022

Choose a reason for hiding this comment

cellio Dec 28, 2022

Choose a reason for hiding this comment

cellio Aug 14, 2023

Choose a reason for hiding this comment

trichoplax Aug 18, 2023

Choose a reason for hiding this comment

Existing delete and destroy buttons

New Delete or Destroy Account section

New Hungry Codidactyl (Delete, Feed to STAT) section

cellio Aug 18, 2023

Choose a reason for hiding this comment

trichoplax commented Feb 2, 2023

cellio commented Feb 2, 2023

ArtOfCode- commented Feb 2, 2023

trichoplax commented Feb 16, 2023 • edited Loading

cellio commented Dec 5, 2024

cellio commented Feb 11, 2025

codecov bot commented Mar 1, 2025

Codecov Report

trichoplax commented Mar 1, 2025

Overview of changes in this branch

Mod tools tab

Private messages

cellio commented Mar 2, 2025

trichoplax commented Mar 2, 2025

trichoplax commented Feb 16, 2023 •

edited

Loading