Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.app.caching caches the form view too strong when modifying descriptions #8

Closed
prakharjoshi opened this issue Mar 3, 2016 · 3 comments · Fixed by #243
Closed
Assignees

Comments

@prakharjoshi
Copy link
Member

When I use collective.easyform in a site in production mode with plone.app.caching enabled and I change the description of a field, the browser will upon requesting the form's /view receive a 304 not modified. Changing the title of a field does force a new reload.

@agitator
Copy link
Member

I'd say this is a configuration issue of p.a.caching

@fredvd fredvd reopened this Dec 18, 2018
@fredvd
Copy link
Member

fredvd commented Dec 18, 2018

I see the same behavior and I don't think this a problem with plone.app.caching per sé. Easyform has to register hooks to activate cachepurging for the urls' on which the form can be viewed when its contents is modified.

The image and file content type for example also purges several @@images/image /@@Download etc urls when the file field is modified. This is different from the default / and /view pages which are by default registered as purge urls by zope and Plone DX.

I've done a quick search through collective.easyform and I see nothing of these registrations for easyform. Furthermore the field editor is not on the default @@edit view so any changes there will not necessarily be picked up automatically like with other /edit views

@mauritsvanrees
Copy link
Member

The real problem is that the catalog counter is not updated, so the catalogCounter ETag stays the same, so any caching that relies on this ETag (pretty standard) will conclude that there are no changes, and give a 304 not modified.
My PR #243 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants