Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: the messages write_something_about_the and item_it_will_be_publicly_visible should be combined #5763

Closed
amire80 opened this issue Jul 8, 2024 · 3 comments · Fixed by #5775
Labels

Comments

@amire80
Copy link
Contributor

amire80 commented Jul 8, 2024

Summary

The messages write_something_about_the and item_it_will_be_publicly_visible are concatenated in run time with a place name. I'm not a Kotlin expert, but as far as I can see, there's no reason not to combine them into one message and insert the place name as a parameter. This will make the message much easier to translate. (Messages that are concatenated in run time are known as "lego" messages in Wikimedia developers jargon, and the convention is to avoid them: https://www.mediawiki.org/wiki/Help:System_message#Avoid_fragmented_or_%22patchwork%22_messages .)

Steps to reproduce

The most difficult thing is to translate the message on translatewiki.

Expected behaviour

It should be one message with a parameter.

Actual behaviour

There are two messages and they are broken up.

Device name

No response

Android version

all of them

Commons app version

current main branch

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

None

@amire80 amire80 added the bug label Jul 8, 2024
@nicolas-raoul

This comment was marked as resolved.

@amire80

This comment was marked as resolved.

@sivaraam
Copy link
Member

Thanks for raising this, @amire80 ! Raised a PR to fixed it in #5775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants