Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to readme.md + comments. #5230

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

tpettwa1
Copy link
Contributor

@tpettwa1 tpettwa1 commented Jun 5, 2023

Made some minor changes to the readme.md file and I also added in some comments for two methods in LoginActivity.java and LatLng.java.

@@ -147,7 +147,7 @@ public void onCreate(Bundle savedInstanceState) {
loginCredentials.setVisibility(View.GONE);
}
}

// Hides the keyboard if the user's focus is not on the password (hasFocus is false).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind using Javadoc-style comments? /** */ Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolas-raoul nicolas-raoul merged commit 3f664d6 into commons-app:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants