Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5285: Do not filter out category that exactly matches the search #5328

Merged

Conversation

Deanstirrat
Copy link
Contributor

Description

Fixes #5285

What changes did you make and why?

added check for exact match on categories upload search function filter.

Tests performed

Tested ProdDebug on Pixel a3 with API level 34.

@Deanstirrat Deanstirrat changed the title fixes #5285: Do not filter out category that exactly matches the search Fixes #5285: Do not filter out category that exactly matches the search Oct 4, 2023
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works great.
Unit tests are passing on my machine.
Thanks a lot! :-)

@nicolas-raoul nicolas-raoul merged commit 05fbfce into commons-app:main Oct 7, 2023
@Deanstirrat Deanstirrat deleted the 5285-fix-category-year-filter branch October 7, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not filter out category that exactly matches the search
2 participants