Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5344 Some categories hidden at top of Upload Wizard suggestions, need to manually scroll up #5370

Conversation

HNYDDDTONY-ANU
Copy link
Contributor

@HNYDDDTONY-ANU HNYDDDTONY-ANU commented Oct 28, 2023

Description (required)

Fixes #5344 Some categories hidden at top of Upload Wizard suggestions, need to manually scroll up

What changes did you make and why?

Modify: DepictsFragment.java/setDepictsList()

  • Add nested depictsRecyclerView.post() function.
  • Ensure that all data has been loaded from the server before executing depictsRecyclerView.smoothScrollToPosition(0);.

Modify: UploadCategoriesFragment.java/setCategories()

  • Add nested rvCategories.post() function.
  • Ensure that all data has been loaded from the server before executing rvCategories.smoothScrollToPosition(0);.

Tests performed (required)

Run the app for manual testing.

Screenshots (for UI changes only)

fix.5344.mp4

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with one picture, it seems to work great!
I will try with a few more.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested more, it works great!
Would you mind modifying the two small things I noted 2 days ago? Then I will merge your pull request. :-)

@HNYDDDTONY-ANU
Copy link
Contributor Author

I tested more, it works great! Would you mind modifying the two small things I noted 2 days ago? Then I will merge your pull request. :-)

OK, I add some comment to describe these blocks.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nicolas-raoul nicolas-raoul merged commit 6f96e89 into commons-app:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some categories hidden at top of Upload Wizard suggestions, need to manually scroll up
2 participants