Removed butterknife from quiz activity #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psh
commented
Nov 12, 2023
| }) | ||
| .setNegativeButton("Cancel", (dialogInterface, i) -> dialogInterface.dismiss()) | ||
| .create() | ||
| .show(); |
There was a problem hiding this comment.
Followed the builder pattern rather than repeating "alert." and since the local variables aren't used outside of this scope, there were inlined.
psh
commented
Nov 12, 2023
| } | ||
| }) | ||
| .create() | ||
| .show(); |
There was a problem hiding this comment.
Similar to the other alert dialog - followed the builder pattern and inlined variables to reduce duplication.
nicolas-raoul
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed butterknife and followed the IDE direction to tidy up code quality warnings.