Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-upload bugs #5389

Conversation

RitikaPahwa4444
Copy link
Collaborator

@RitikaPahwa4444 RitikaPahwa4444 commented Nov 19, 2023

Description (required)

Fixes #5377

What changes did you make and why?

Removed redundant calls to checkStoragePermissions() from multiple activity lifecycle components so that it receives shared items only once.

Tests performed (required)

Tested prodDebug on Redmi 5A with API level 27.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with about 10 multiuploads, it works great.
Thanks a lot Ritika for saving the situation again!

@nicolas-raoul nicolas-raoul merged commit d967279 into commons-app:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several multi-upload bugs since a few days
2 participants