-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Mapbox with osmdroid (Nearby activity) #5403
Conversation
# Conflicts: # app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great!
Hopefully unit tests can be fixed. :-)
I just added a few comments.
Thanks a lot for the nice code!
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/RotationGestureOverlay.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The location is now updated at least when restarting the app, thanks for fixing! 🙂
The unit tests are the next priority, I guess.
Minor thing: Would it be possible to close the pin labels at some point, for instance when tapping another pin, so that at most one label is open at any time? If difficult it can be done later, possibly by someone else, no worries.
Feel free to add |
Hi @nicolas-raoul , I have made the changes as advised by you and I have also fixed the marker click issue. Marker.Click.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @kanahia1 for this very needed change!
It works great.
I created #5408 |
Fixes #5372
What changes did you make and why?
✔️ Replaced MapBox with OSMDroid
✔️ Tested most of the pre-existing features
Tests performed (required)
Tested betaDebug on Samsung S21 FE with API level 33.
Screenshots (for UI changes only)
https://github.com/commons-app/apps-android-commons/assets/114223204/501e79a8-bf8e-4a3a-8499-f0490e46af3c
🔧 Need to work on tests