Send thanks button in more details fragment #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Working great!
I checked all places I could think of where images are visible, then checked that the thanks were correctly sent (at https://commons.wikimedia.org/wiki/Special:Log?type=thanks&user=Syced&page=&wpdate=&tagfilter=&wpFormIdentifier=logeventslist)
| @@ -431,6 +447,12 @@ public void onResume() { | |||
| enableProgressBar(); | |||
| } | |||
|
|
|||
| if (AccountUtil.getUserName(getContext()) != null && media != null && AccountUtil.getUserName(getContext()).equals(media.getAuthor())) { | |||
There was a problem hiding this comment.
How about splitting this very long line?
app/src/main/res/values/strings.xml
Outdated
| @@ -784,6 +784,8 @@ Upload your first media by tapping on the add button.</string> | |||
| <string name="storage_permissions_denied">Storage Permissions Denied</string> | |||
| <string name="unable_to_share_upload_item">Unable to share this item</string> | |||
| <string name="permissions_are_required_for_functionality">Permissions are required for functionality</string> | |||
| <string name="send_thanks_to_author">Send thanks to author</string> | |||
There was a problem hiding this comment.
How about a shorter "Thank the author"?
|
In order to fix the unit tests, would you mind rebasing (or pulling) from main? Thanks :-) |
|
@nicolas-raoul made the changes, sorry for the delay |
nicolas-raoul
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5421
What changes did you make and why?
Send thank button will appear only when the image is not uploaded by author.
Tests performed (required)
Tested prodDebug on Samsung galaxy M31 with API level 31.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.