Resolves #5445 highlighting nearest place on clicking home nearby banner #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-raoul I added functionality for highlighting nearest place only when user clicks on banner, as I felt that, highlighting it always would make the home banner click redundant and would defeat it's purpose. If you feel otherwise, then I can modify it. |
|
@nicolas-raoul my apologies, I missed checking NPE while calling function in onResume |
nicolas-raoul
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5445
What changes did you make and why?
Added method to change marker icon if place is nearest, when user clicks on home nearby banner and also highlight the bottom sheet details of that particular place. Also fixed the home nearby banner to keep displaying even after clicks on it and comes back to it later (which wasn't happening earlier)
Tests performed (required)
Tested prodDebug on OnePlus Nord CE 2 Lite with API level 31
Screenshots (for UI changes only)
Video showing functionality of app in dark and light mode:
https://drive.google.com/file/d/1ZmxEvQ05mT82A5uz1D4eEI2DmtSRpWCf/view?usp=share_link