Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve displaced icons problem for small screens sizes #5467

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

rohit9625
Copy link
Contributor

Description (required)

Fixes #5460

What changes did you make and why?
Make changes in the file styles.xml, i.e., remove color styles for floatingActionButton because it's causing displaced icons for small screens in the contributions and nearby tab.
Also, removed the tint attribute from a button having the description Add new contribution.

Tests performed (required)
Manually tested.

Tested betaDebug and prodDebug on Pixel with API 30.

Screenshots (for UI changes only)
Previously
298384428-c5e35234-4614-44b2-8338-4dca72f2b27e

Now
298621211-3b39fa09-40dd-450b-b7cb-baed332ac9a8

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

@nicolas-raoul nicolas-raoul merged commit ab35403 into commons-app:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displaced icons in Contributions/Nearby/Explore tab
2 participants