Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement-Show Icon Labels When Long Pressed #5492

Merged

Conversation

shashankiitbhu
Copy link
Contributor

Description (required)

Fixes #5470

What changes did you make and why?
Added onLongClickListeners to Icons that do not have Visible Labels to show Toast with the Labels of corresponding Icons to make it more user-friendly.

Tests performed (required)

Tested 4.2.1-debug on Xiaomi 11 lite NE with API level 33.

Screenshots (for UI changes only)
WhatsApp Image 2024-01-29 at 12 43 11 PM
WhatsApp Image 2024-01-29 at 12 43 12 PM
WhatsApp Image 2024-01-29 at 12 43 14 PM

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks!

@nicolas-raoul nicolas-raoul merged commit 8bafee3 into commons-app:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Details About Icon Labels when long pressed
2 participants