Remove the data-client app adapter implementation #5499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started off as a simple "Let's slim down the commons app-adapter" and as it got toward the end, turned into "OK, this thing has surely got to go!"
It was worked as a series of discrete steps, to remove one method from the app-adapter at a time, so if you look at the commits it might be a little easier to follow. Mostly they're removing unused methods or inlining single-line methods.
High-level overview -
SharedPreferenceCookieManager
was broken into 2 pieces - cookie jar (integration with OkHttp) and cookie storage (integration with shared preferences). Each was converted to Kotlin and now managed using dependency injection.LogoutClient
.This PR relates to the discussion in #5165