Fix Crash Edit Categories Fragment #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-raoul @psh @RitikaPahwa4444 Please Review and Merge this PR, because it solves an Important Crash #5505 , thanks :) |
There was a problem hiding this comment.
I confirm this fixes the crash when editing categories of my contributions.
I am now waiting for resolution of #5547 to test for possible side effects.
|
@nicolas-raoul I Added some checks and appropriate tests |
|
@nicolas-raoul If these tests and checks are fine , can you please review and merge this, thanks |
nicolas-raoul
approved these changes
Feb 26, 2024
ShashwatKedia
pushed a commit
to ShashwatKedia/apps-android-commons
that referenced
this pull request
Mar 1, 2024
* fix crash * Tests Added * Tests and Null Checks Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5505
What changes did you make and why?
Removed an unnecessary check that was stopping the
init()from getting called which was resulting in a crash.Tests performed (required)
Tested 4.2.1-debug-main on Xiaomi 11 Lite NE with API level 33