Fixes #5408 [Fix the 36 unit tests that started failing when switching from MapBox to OpenStreetMap (now set as @Ignored)] #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Feb 11, 2024
app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
|
sure |
domdomegg
reviewed
Feb 12, 2024
app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
domdomegg
reviewed
Feb 12, 2024
app/src/test/kotlin/fr/free/nrw/commons/nearby/NearbyParentFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
|
Hi @nicolas-raoul @domdomegg worked on the review points pls check |
domdomegg
approved these changes
Feb 13, 2024
|
Hmm the tests seem to be failing - can you take a look @tamojitdas? |
|
Sure, but before that would like to know the details of the failures ..can you post some snapshots of the errors u getting. |
|
hmm,ok I will look into it tomorrow |
|
Hi @domdomegg @nicolas-raoul Updated the NearbyParentFragmentPresenterTest.kt class for 100% passing of tests...Please Not that other failed test classes are not falling under this current initiative hence kept it BAU(not changed anything there).
Thanks. |
domdomegg
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5408
What changes did you make and why?
Updating of Unit Tests methon on class :: NearbyParentFragmentPresenterTest.kt (Marked as @ignore earlier) to work successfully.
Note :: Need Some Assistance on NearbyParentFragmentUnitTest.kt hence skipped for Now... (anyone can also take up from the changes I have made so far)
Tests performed (required)
Tested app:testBetaDebugUnitTest on Medium Phone API UpsideDownCakePrivacySandbox with API level 33.
🔧 Need to work on tests