Fix DNG/RAW Upload Error #5543
Merged
Fix DNG/RAW Upload Error #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaraam
requested changes
Feb 13, 2024
app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFileLoader.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/filepicker/FilePicker.java
Outdated
Show resolved
Hide resolved
|
@sivaraam Made the changes according to the supported formats mentioned on the webpage, Please Review it |
nicolas-raoul
requested changes
Feb 14, 2024
|
|
||
| val extension = path.substringAfterLast(".", "") | ||
| // Check if the extension is one of the allowed types | ||
| if (extension.lowercase(Locale.ROOT) in arrayOf("jpg", "jpeg", "png", "svg", "gif", "tiff", "webp", "xcf")) { |
There was a problem hiding this comment.
Can you please do if ( ! extension.lowercase(Locale.ROOT) in arrayOf(...?
Process exceptional cases first, then go on with the normal flow.
This avoids too may levels of if else.
See https://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html
nicolas-raoul
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5537
What changes did you make and why?
Restrict users to only pick Images whose types are allowed by Wikimedia Commons (as mentioned here: https://commons.wikimedia.org/wiki/Commons:File_types)
Tests performed (required)
Tested 4.2.1-debug-main on Xiaomi 11 Lite NE with API level 33
Screenshots (for UI changes only)