Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Kotlin synthetics to Jetpack view binding #5546

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

domdomegg
Copy link
Member

Description (required)

Partially addresses #4664

Migrates from Android extensions to Jetpack view binding, as per https://developer.android.com/topic/libraries/view-binding/migration

Tests performed (required)

Tested BetaDebug on Pixel 3a emulator with API level 34.

@domdomegg domdomegg force-pushed the jetpack-view-binding branch from e6c061e to 8f7a692 Compare February 13, 2024 01:10
@domdomegg domdomegg marked this pull request as ready for review February 13, 2024 01:22
@@ -5,7 +5,7 @@ apply from: '../gitutils.gradle'
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt'
apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-parcelize'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'kotlin-android-extensions' is deprecated so we're removing it in place of view binding instead.

We use parcelize, which is part of the old extensions plugin. It's now been moved out to its own plugin, hence we're adding that one back in. From from https://developer.android.com/topic/libraries/view-binding/migration:

Note: If your app uses Parcelable features, switch to using the standalone kotlin-parcelize Gradle plugin described in Parcelable implementation generator.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, upload still working fine

@nicolas-raoul nicolas-raoul merged commit 1cbce77 into commons-app:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants