Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thumbnail of rotated image not visible during upload #5552

Conversation

mshdabiola
Copy link
Contributor

@mshdabiola mshdabiola commented Feb 15, 2024

fixed: thumbnail not visible when upload rotated image

The image path of rotated image is not save like normal image. so image view cannot load rotated image

check whether the image path is file uri then add image request to load the image

Fixes #5363

What changes did you make and why?

Tests performed (required)

Tested BetaDebug on Tecno with API level 28.

[The image path of rotated image is not save like nornal image.
so imageview cannot load rotated image

check whether the image path is file uri then add imagerequest to load the image]

[fixed: thumbnail not visible when upload rotated image]
Copy link
Contributor

@rohit9625 rohit9625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review By Student

Before:

rotate_image_bug_before.-.Trim.mp4

After:

rotate_bug_after.-.Trim.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thanks a lot! :-)

@nicolas-raoul nicolas-raoul merged commit 751bc6c into commons-app:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Thumbnail not visible while uploading rotated image
3 participants