Resolve switching languages problem in settings fragment #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by student - Works for me! 2024_02_22_14_48_08_trim.mp4After: 2024_02_22_14_55_07_trim.mp4 |
|
Thank you for reviewing it @srishti-R :) |
srishti-R
approved these changes
Feb 22, 2024
nicolas-raoul
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5501
What changes did you make and why?
I added a method
createLocale, for creating a Locale based on language codes specifically for those with'-'(hyphen).Because the Local object can have three parameters
code, country, and variant, so we need to split language code before passing it.I also added some tests for the
createLocalemethod.Tests performed (required)
Tested prodDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)