Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert API clients to kotlin #5567

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

psh
Copy link
Collaborator

@psh psh commented Feb 19, 2024

Most of the API Client classes (that use our Retrofit interfaces) are already in Kotlin. This PR improves tests and then converts 4 of the remaining ones to kotlin -

  • UserClient
  • WikidataClient
  • WikiBaseClient
  • ReviewHelper

Note: this relates to the discussion in #4665

@nicolas-raoul nicolas-raoul merged commit 728712c into commons-app:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants