Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4704: Remove 'Please Wait' dialog and do task in background #5570

Merged
merged 16 commits into from
Mar 27, 2024

Conversation

ShashwatKedia
Copy link
Contributor

@ShashwatKedia ShashwatKedia commented Feb 22, 2024

Description (required)

Fixes #4704

What changes did you make and why?

Implemented the flow, as discussed here. Changed the logic of the upload flow quite a lot to calculate and store the image quality of all the images at once and display the problems dialog as soon as the image comes into play.

Tests performed (required)

Tested prodDebug on OnePlus Nord CE 2 Lite with API level 31.

Screencast of the app after changes were implemented

Link to screencast

@ShashwatKedia ShashwatKedia marked this pull request as draft February 22, 2024 06:33
@ShashwatKedia ShashwatKedia force-pushed the issue4704SK branch 2 times, most recently from 447785c to b7e3573 Compare March 1, 2024 13:23
@ShashwatKedia ShashwatKedia marked this pull request as ready for review March 4, 2024 22:00
@ShashwatKedia ShashwatKedia changed the title Draft PR: Remove 'Please Wait' dialog and do task in background Fixes #4704: Remove 'Please Wait' dialog and do task in background Mar 4, 2024
Copy link
Member

@misaochan misaochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested this, but the screencast looks good to me.

@ShashwatKedia ShashwatKedia force-pushed the issue4704SK branch 2 times, most recently from de8c549 to e8b0a4c Compare March 22, 2024 05:01
@ShashwatKedia
Copy link
Contributor Author

@nicolas-raoul @sivaraam could you please take a look at this PR :)

@ShashwatKedia
Copy link
Contributor Author

@nicolas-raoul @sivaraam could either of you please take a look at this, if you find this worthy enough :)

@nicolas-raoul
Copy link
Member

With this branch I still see the Please wait dialog in-between images, is that expected?

@nicolas-raoul
Copy link
Member

screen-20240327-155440.mp4

@ShashwatKedia
Copy link
Contributor Author

ShashwatKedia commented Mar 27, 2024

With this branch I still see the Please wait dialog in-between images, is that expected?

@nicolas-raoul , Please Wait dialog will have to be there, because caption has to be checked everytime user hits submit button (as it can be changed by user). What I have done is checking the quality of the image as soon as it's loaded (and storing that of the next ones), instead of when user enters all description and hits submit, just to be told that the image is already present on Commons, etc. Here is the flow I implemented and screencast is present in the description of this PR. Please let me know your thoughts on this :)

@nicolas-raoul
Copy link
Member

Ah understood I had forgotten about title check thanks! :-)

@nicolas-raoul nicolas-raoul merged commit 4264164 into commons-app:main Mar 27, 2024
1 check passed
@rohit9625 rohit9625 mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload wizard: Remove "Please wait" if possible and do the task in background
3 participants