-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4704: Remove 'Please Wait' dialog and do task in background #5570
Conversation
ab0a2cf
to
1e9b4e4
Compare
447785c
to
b7e3573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested this, but the screencast looks good to me.
de8c549
to
e8b0a4c
Compare
@nicolas-raoul @sivaraam could you please take a look at this PR :) |
@nicolas-raoul @sivaraam could either of you please take a look at this, if you find this worthy enough :) |
e8b0a4c
to
d5e8631
Compare
With this branch I still see the |
screen-20240327-155440.mp4 |
@nicolas-raoul , |
Ah understood I had forgotten about title check thanks! :-) |
Description (required)
Fixes #4704
What changes did you make and why?
Implemented the flow, as discussed here. Changed the logic of the upload flow quite a lot to calculate and store the image quality of all the images at once and display the problems dialog as soon as the image comes into play.
Tests performed (required)
Tested prodDebug on OnePlus Nord CE 2 Lite with API level 31.
Screencast of the app after changes were implemented
Link to screencast