Migrate Upload Package To View Binding from Butterknife

[shashankiitbhu]

Description (required)

Related to #4664

What changes did you make and why?

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

[neeldoshii]

Is this PR ready to review? @shashankiitbhu

Thanks.

Also just a feedback next time can you please create a package a PR.

Few reasons:-

1. This can lead to big workaround on merge conflict if someone else working on the same package and got things merged, also one single package its easy to get reviewed, fixing merge conflicts and faster merge.

2. I don't have issue in reviewing multiple package at once but single package a pr would be best if someone (maintainer) if wishes to take a revert by some reason. Currently you have all the things in one commit. Reverting a commit will revert 19 packages to butterknifebinding whereas we just wanted to revert a package.

[shashankiitbhu]

@neeldoshii yes

[neeldoshii]

Left few minor code optimisation rest its good to go. I ran through the code locally. For unused optimisation fix this for this PR whichever files you touched. I will be adding klint #5198 in the project which will be ease in all this refactoring locally before commit.

Edit : Removed Feedback because of misunderstanding from my side.
Once the changes are done, its aprooved from my side.
Thank @shashankiitbhu
Review by Student

[shashankiitbhu]

Also just a feedback next time can you please create a package a PR.

I added Per Package only in all of my PRs if you check carefully. Only one test is included in the PR which is related to that Package

[neeldoshii]

Also just a feedback next time can you please create a package a PR.

I added Per Package only in all of my PRs if you check carefully. Only one test is included in the PR which is related to that Package

Apologies, my bad I took one file per PR.