-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Bookmarks Package From Butterknife to ViewBinding #5594
Conversation
app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesFragment.java
Outdated
Show resolved
Hide resolved
ButterKnife.bind(this, v); | ||
binding = FragmentBookmarksPicturesBinding.inflate(inflater, container, false); | ||
View v = binding.getRoot(); | ||
gridView = binding.bookmarkedPicturesList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this, this does the work but doesnt give you the optimality.
This will make you have import android.widget.GridView;
which is unnecessary as this will make uneccessary import and we will lose the advantage of viewbinding here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer PR #5598
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I was using this for tests to work, In your original PR you were not handling tests (checks did not run on your PR), but I have found a better way to handle tests now.
app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/bookmarks/items/BookmarkItemsFragment.java
Show resolved
Hide resolved
Hi @shashankiitbhu, Review by Student. |
@neeldoshii will look at them soon, thanks |
Thanks for the contribution.
Review by Student. |
Description (required)
Related to #4664
What changes did you make and why?
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.