Refactor : API calls moved out of the LoginActivity #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psh
reviewed
Mar 4, 2024
psh
requested changes
Mar 4, 2024
app/src/main/java/fr/free/nrw/commons/auth/login/LoginClient.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/auth/login/LoginClient.kt
Outdated
Show resolved
Hide resolved
|
Do i need to squash merge all my commits into one? |
psh
approved these changes
Mar 6, 2024
|
Thank you for the fixes! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Approach
I have moved the API logic (business logic) from login activity to login client.
Testing Instructions
Tests performed
Test performed on Google Pixel 6 API 24 (Emulator).
Feel free to place your opinion and reviews.