Migrated Media Package to View Binding #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeldoshii
suggested changes
Mar 5, 2024
|
@psh Resolved the merge conflict , Please Review |
shashankiitbhu
force-pushed
the
media_binding
branch
from
47951ff to
cc82fd3
Compare
# Conflicts: # app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
psh
reviewed
Mar 20, 2024
app/src/test/kotlin/fr/free/nrw/commons/media/MediaDetailPagerFragmentUnitTests.kt
Outdated
Show resolved
Hide resolved
psh
reviewed
Mar 20, 2024
app/src/test/kotlin/fr/free/nrw/commons/media/MediaDetailFragmentUnitTests.kt
Outdated
Show resolved
Hide resolved
psh
reviewed
Mar 20, 2024
app/src/main/java/fr/free/nrw/commons/media/ZoomableActivity.kt
Outdated
Show resolved
Hide resolved
psh
requested changes
Mar 20, 2024
|
@psh Made the required changes |
psh
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4664
What changes did you make and why?
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Screenshots (for UI changes only)