Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality to export location of nearby missing pictures to GPX file and KML file #5645

Merged
merged 56 commits into from
Mar 25, 2024
Merged

Added functionality to export location of nearby missing pictures to GPX file and KML file #5645

merged 56 commits into from
Mar 25, 2024

Conversation

kanahia1
Copy link
Contributor

Description (required)

Added functionality to export location of nearby missing pictures to GPX file and KML file
Fixes #953

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)

WhatsApp.Video.2024-03-24.at.19.18.58_f106b22c.mp4

kanahia1 and others added 30 commits October 21, 2023 02:32
@kanahia1
Fixed Grey empty screen at Upload wizard caption step after denying f…
b6a2151 
…iles permission
@kanahia1
Empty commit
f916e1f
@kanahia1
Merge remote-tracking branch 'origin/main'
b75193b 
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
@kanahia1
Fixed loop issue
98473a1
@kanahia1
Created docs for earlier commits
f5f050e
@kanahia1
Fixed javadoc
1b3bd3d
@kanahia1
Merge branch 'commons-app:main' into main
9a9e285
@kanahia1
Fixed spaces
896c1d9
@kanahia1
Merge branch 'commons-app:main' into main
5ae7550
@kanahia1
Added added basic features to OSM Maps
365dd76
@kanahia1
Added search location feature
4ffafd8
@kanahia1
Added filter to Open Street Maps
2e3d690
@kanahia1
Fixed chipGroup in Open Street Maps
59d21d2
@kanahia1
Removed mapBox code
ac453df
@kanahia1
Merge branch 'commons-app:main' into main
ad564d3
@kanahia1
Removed mapBox's code
a6cbb27
@kanahia1
Reformat code
0cedf17
@kanahia1
Reformatted code
9919ac5
@kanahia1
Removed rotation feature to map
e0e0850
@kanahia1
Removed rotation files and Fixed Marker click problem
3a6365f
@kanahia1
Merge branch 'main' into main
a017314
@kanahia1
Ignored failing tests
3069518
@kanahia1
Added voice input feature
fc1855c
@kanahia1
Merge remote-tracking branch 'origin/main'
7fdd88f
@kanahia1
Fixed test cases
78666c6
@kanahia1
Merge branch 'commons-app:main' into main
c9ae0d9
@kanahia1
Merge branch 'commons-app:main' into main
3972967
@kanahia1
Changed caption and description text
0dc6b11
@kanahia1
Merge branch 'main' into main
bcda966
@kanahia1
Merge branch 'commons-app:main' into main
23459cb
kanahia1 and others added 21 commits January 16, 2024 00:30
@kanahia1
Merge branch 'commons-app:main' into main
23717c3
@kanahia1
Merge remote-tracking branch 'origin/main'
1d091f4
@kanahia1
Fixed Unit Tests
c6f7e6f
@kanahia1
Made selected marker to be fixed on map
cb6dfb7
@kanahia1
Changed color of map marker
9814bfe
@kanahia1
Merge branch 'commons-app:main' into main
3ac441c
@kanahia1
Fixes commons-app#5439 by capitalizing first letter of voice input
cd69c81
@kanahia1
Merge branch 'main' into issue5439
c5bf7ff
@kanahia1
Merge branch 'main' into issue5439
23626d2
@kanahia1
Merge branch 'main' into issue5439
bd6e039
@kanahia1
Merge branch 'commons-app:main' into issue5439
bcca120
@kanahia1
Merge remote-tracking branch 'origin/issue5439' into issues5439
1df5e2c
@kanahia1
Merge branch 'commons-app:main' into issue5439
9380f47
@kanahia1
Merge remote-tracking branch 'origin/issue5439' into issues5439
e26d270
@kanahia1
Removed mapbox code1
6b9f261
@kanahia1
Removed mapbox code2
1ed9064
@kanahia1
Fixed failing tests
60138b5
@kanahia1
Merge branch 'main' into issues5439
a0ef312
@kanahia1
Fixed failing due to merging
dd31041
@kanahia1
Added feature to save nearby places as GPX and KML
4ff3243
@kanahia1
Merge branch 'issue953' of https://github.com/kanahia1/apps-android-c…
c459325 
…ommons into issue953
@kanahia1 kanahia1 mentioned this pull request Mar 24, 2024
Closed
@nicolas-raoul
Copy link
Member

Looks extremely promising. unfortunately I amnmjw no getting this error every time, while the Nearby map UI itself works fine:

Screenshot_20240325-092543.png

By the way, it makes me realize two things:

  • a dedicated "Fetching points..." dialog would make it clearer that it is not just the map loading.
  • This dialog could, at the end, show the path of the generated file and display a button to open it. Many users have never used a file browser on Android. The user will probably just want to load the file in their navigation app. Most such apps save the points in their own database permanently, so the file is then not needed anymore.
    This can be a separate issue/PR. 🙂

@kanahia1
Copy link
Contributor Author

@nicolas-raoul, Thanks for reporting issues. I have fixed the issue faced by you in c633593 and will fix user experience related in different PR.

WhatsApp.Video.2024-03-25.at.11.29.12_de339729.mp4

@kanahia1
Copy link
Contributor Author

Hey @nicolas-raoul, here is something I have came with

WhatsApp.Video.2024-03-25.at.17.30.58_89b8e250.mp4

I will share new pull request as soon as this gets merged 🙌

nicolas-raoul
nicolas-raoul approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things could be improved, but already a great feature so merging and will create issues.
Thanks a lot! :-)

@nicolas-raoul nicolas-raoul merged commit c419402 into commons-app:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export location of nearby missing pictures to GPX file
2 participants
@kanahia1 @nicolas-raoul