Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adaptive Icon #5687

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add Adaptive Icon #5687

merged 3 commits into from
Apr 16, 2024

Conversation

RedAuburn
Copy link
Contributor

@RedAuburn RedAuburn commented Apr 11, 2024

Description

add monochrome icon variant, allows for Adaptive Icon theming on android 13 and above.
(see https://developer.android.com/develop/ui/views/launch/icon_design_adaptive)
(doesn't overwrite existing icon, only applies when themed icons are enabled)

Tests performed

Tested betaRelease on Oneplus 9 Pro with API level 34.

Screenshot
before/after
Screenshot_20240411-175002_Trebuchet

allows for better theming on android O and above.
@RedAuburn
Copy link
Contributor Author

test failed due to #5688

@nicolas-raoul
Copy link
Member

Sorry would you mind removing app/src/main/res/values-yue-hant as well, for the unit tests to correctly check this PR?
Thanks a lot! :-)

@RedAuburn
Copy link
Contributor Author

RedAuburn commented Apr 13, 2024

Sorry would you mind removing app/src/main/res/values-yue-hant as well, for the unit tests to correctly check this PR? Thanks a lot! :-)

fixed 👍️ although won't it be re-added when the translatewiki bot does its next translation merge?

@nicolas-raoul
Copy link
Member

Yes there is another issue about fixing yue-hant permanently. :-)

@nicolas-raoul nicolas-raoul merged commit 1f2e31d into commons-app:main Apr 16, 2024
1 check passed
@RedAuburn RedAuburn deleted the adaptive-icon branch April 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants