Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #4787: Update Java version from Java 8 to Java 11 #5732

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

elemcraft
Copy link
Contributor

Description (required)

Fixes #4787

What changes did you make and why?
Changes the JavaVersion.VERSION_1_8 to JavaVersion.VERSION_11 in build.gradle

Tests performed (required)

Tested betaDebug, betaRelease, and prodDebug on emulator Pixel 6 API 34

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@elemcraft elemcraft changed the title Update Java version from Java 8 to Java 11 Fixes Issue4787: Update Java version from Java 8 to Java 11 Jun 9, 2024
@elemcraft elemcraft changed the title Fixes Issue4787: Update Java version from Java 8 to Java 11 Fixes Issue #4787: Update Java version from Java 8 to Java 11 Jun 9, 2024
@nicolas-raoul
Copy link
Member

Sorry for the delay!
Would you mind posting a screencast showing an upload being performed, using this branch?
Thanks a lot!

@elemcraft
Copy link
Contributor Author

Hello, @nicolas-raoul

No worries. This is the upload I ran on virtual device Pixel 6 API 34

image
image

@nicolas-raoul
Copy link
Member

Thanks!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested, all main features still working. Thanks for your contribution!

@nicolas-raoul nicolas-raoul merged commit bde0907 into commons-app:main Jun 9, 2024
1 check passed
@elemcraft
Copy link
Contributor Author

Thank you for giving me this chance to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving to JDK 11?
2 participants