Prevent deletion of other structured data when editing depicts #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get Method: to get claims for an entity Post method: to delete claims
Refactor methods to perform well with coroutines
Performs deletion of old claims and creation of new claims
|
Thank you for these changes! It's great that you were able to identify a workaround for the whole structured data being removed by only removing and adding the depictions. While this is an improvement from the status quo, it would be great if we could use more optimal route of just achieving this in a single edit rather than two (if possible). Could you possibly check the feasibility of the same by writing to the wikitech-l / Commons-l mailing list ? |
nicolas-raoul
approved these changes
Aug 26, 2024
app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsPresenter.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Before: Previously, the API was deleting whole entity data and updating with new depictions.
Now: Two APIs are used to delete older depictions only and update with the new ones.
Fixes #5728
What changes did you make and why?
Major Changes
WikiBaseInterface.kt: Added new methods to use two new APIs to get the work done.WikidataEditService: Updated method to update depictions that performs deletion and creation of depiction. Although, added some utility functions for convenience.Some Additional Changes
File
DepictsDao.kt, was using runBlocking to perform database operations, resulting in the blocking of the current Thread in which the runBlocking was used. So, I replaced them with theCoroutines.Some minor changes to related files for better readability
Tests performed (required)
Tested ProdDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)
None