Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Map Marker Visibility Based on App Theme #5744

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

vtalos
Copy link
Contributor

@vtalos vtalos commented May 27, 2024

Description

Fixes #5742

This pull request addresses the visibility of map markers by dynamically adjusting their colors based on the app's theme. The map markers will now appear lighter when the app is in dark mode and darker when the app is in light mode. This change aims to enhance marker visibility and improve the overall user experience.

Tests performed

Tested ProdDebug on Pixel 3 with API level 34

Screenshots

Light Theme:
Screenshot_20240527_124300

Dark Theme:
Screenshot_20240527_124343

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks!

@nicolas-raoul nicolas-raoul merged commit 22dd69c into commons-app:main Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Colors of existing / not existing pins are very similar
3 participants