Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated skip_login_title string to sound more natural #5746

Merged
merged 1 commit into from
May 30, 2024

Conversation

pacha0
Copy link
Contributor

@pacha0 pacha0 commented May 29, 2024

Updated skip_login_title string in strings.xml to sound more natural

Fixes n/a

What changes did you make and why?
Updated skip_login_title string in strings.xml from "would have to log in" to "will have to log in" to sound more natural

Tested n/a

@nicolas-raoul
Copy link
Member

Maybe "would" conveys the fact that it is hypothetical? Some people do not plan to upload pictures in the future, they just use Commons to find illustrations.

@pacha0
Copy link
Contributor Author

pacha0 commented May 29, 2024

I agree that it is hypothetical but it is still a realistic and expected outcome, therefore I believe it fits better with a "first conditional sentence" (realistic future event) instead of a "second conditional" (unrealistic future event). That is probably why I thought "will" sounded more natural: first conditionals call for "will" while second conditionals call for "would".

First conditionals do not have to be guaranteed events since they're still contingent on something else happening (in this situation, the user wanting to upload a picture).

Sorry for the very nitty pull request, hopefully I'll pick up some meatier stuff soon. I just wanted to get started with something I noticed right away. :)

@nicolas-raoul nicolas-raoul merged commit ff21e73 into commons-app:main May 30, 2024
@nicolas-raoul
Copy link
Member

Makes sense, thanks for your contribution!
Do not hesitate to send other pull requests even if it seems nitty. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants