Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new feedback to be added as a new section to the end of the page #5753

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

sivaraam
Copy link
Member

@sivaraam sivaraam commented Jun 9, 2024

Description (required)

Addresses #5542

For auto-archiving of section to work properly on our feedback page, the new sections need to be created at the end of the page rather than at the top.

So, adjust the feedback addition logic to make it such that the feedback is appended to the bottom of the page.

Tests performed (required)

Tested on a OnePlus Nord running API 32.

Section reference (for UI changes only)

Section created using these changes can be found here: https://commons.wikimedia.org/wiki/Commons:Mobile_app/Feedback#Feedback_from_Kaartic_for_version_5.0.1-debug-feedback-append~8fdfb8e6d


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

sivaraam added 3 commits June 9, 2024 11:21
Addresses feedback on #5542. For auto-archiving of section
to work properly on our feedback page, the new sections need to
be created at the end of the page rather than at the top.

So, adjust the feedback addition logic to make it such that the
feedback is appended to the bottom of the page.
The summary of the feedback page was unhelpful. Make it more helpful by
using a more helpful summary that at least mentions the version of the
app for which the feedback is posted.
@sivaraam sivaraam requested a review from nicolas-raoul June 9, 2024 05:56
@sivaraam sivaraam changed the title Feedback append Make new feedback to be added as a new section to the end of the page Jun 9, 2024
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have computer access this weekend so I did not test, but LGTM!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-raoul nicolas-raoul merged commit 1808699 into main Jun 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants