Replaced the 'Add location' button with 'Edit location' button when user clicks yes in similar image dialog #5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation' button when user clicks yes in similar image dialog
nicolas-raoul
approved these changes
Jun 15, 2024
|
Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an Issue to change the name of the 'add location' button's text to 'edit location' if the user was copying the location of a recently uploaded image.
Fixes: #5669
What changes did you make and why?
We were able to do this by editing "UploadMediaDetailFragment.java". We wrote code that replaced the button if the user clicks yes for the similar image dialog, which fixed the issue.
Tests performed
We followed the guide given in the issue to reproduce the results and when we performed them with the newly written code, it produced the expected behavior.
Tested betaDebug on Pixel 8 with API level 34.
Screenshot
