First of two fixes for bug #5726: hide nominate for deletion when logged out #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when logged out
nicolas-raoul
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5726
What changes did you make and why?
Added more if statements into "onDeletionPageExists" function so that guest users won't have the capability to nominate an image for deletion.
Tests performed (required)
Manually tested by compiling and running the app (As guest and logged in)
I also ran the UnitTests in which all of them passed
Tested {build variant, e.g. ProdDebug} on {What Emulator used} with API level {Level}.
Screenshots (for UI changes only)
When the user isn't logged in
When the user is logged in
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.