(fixes #5855) fetch item label in nearby based on user configured lan… #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figured language.
|
@nicolas-raoul would you be able to review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Nearby functionality to fetch Item tag based on user's preferred language
Currently, the nearby feature, fetches all the labels to be in English. However, the expected behaviour would be to fetch based on user's preferred language.
Fixes #5855
What changes did you make and why?
The only change made was to the query file. It was updated to fetch labels based on
{LANG}variable.Tests performed (required)
Tested
ProdDebugon Pixel 7 with API level 34 to ensure that Wiki Items were presented with labels in user language if available. Tested for the Wiki Item Bust of Gustave Eiffel. The languages tested were, French, Armenian, Arabic & Turkish. Before each screenshot was taken, language preference was updated and then the item was located in Nearby.