Fixes #5725 allowing multiple language changes #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>> Made it so that selecting a language results in the hashmap storing the currently selected language(s) being cleared. Considered refactoring the hashmap storing this into a single pair storing the language positition index and its code, as only one language should ever be selected, however I am not confident that this would not introduce unintended side-effects
…mmons into allowMultipleLanguageChanges
|
Thanks @cambo14 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting multiple languages while uploading media, selecting a new language can result in the old language still showing as selected and not being able to be selected again.
Fixes #5725
What changes did you make and why?
UploadMediaDetailAdaptor.java:
Tests performed (required)
Tested ProdDebug on Samsung S23 SM-S911B with API level 34 by selecting many various languages from both the full language list and recent language lists, as shown in the screenshots section below
Screenshots (for UI changes only)
Screen_Recording_20241022_154801_Commons.3.mp4