Security : Migrated exifInterface to androidx exif.interface #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeldoshii
commented
Dec 8, 2024
| @@ -66,13 +63,13 @@ class EditActivity : AppCompatActivity() { | |||
| ExifInterface.TAG_GPS_TIMESTAMP, | |||
| ExifInterface.TAG_IMAGE_LENGTH, | |||
| ExifInterface.TAG_IMAGE_WIDTH, | |||
| ExifInterface.TAG_ISO, | |||
There was a problem hiding this comment.
For reviewers:
As per linked issue I migrated to TAG_ISO to TAG_ISO_SPEED_RATINGS but this ISO_SPEED_Ratings is deprecated in androidx.exifinterface.media.ExifInterface so I migrated it to TAG_PHOTOGRAPHIC_SENSITIVITY
neeldoshii
commented
Dec 8, 2024
| ExifInterface.TAG_MAKE, | ||
| ExifInterface.TAG_MODEL, | ||
| ExifInterface.TAG_ORIENTATION, | ||
| ExifInterface.TAG_WHITE_BALANCE, | ||
| ExifInterface.WHITEBALANCE_AUTO, |
There was a problem hiding this comment.
For reviewers:
Deprecated in androidx
Ref : https://developer.android.com/reference/kotlin/androidx/exifinterface/media/ExifInterface#WHITEBALANCE_AUTO()
neeldoshii
commented
Dec 8, 2024
| ExifInterface.TAG_MAKE, | ||
| ExifInterface.TAG_MODEL, | ||
| ExifInterface.TAG_ORIENTATION, | ||
| ExifInterface.TAG_WHITE_BALANCE, | ||
| ExifInterface.WHITEBALANCE_AUTO, | ||
| ExifInterface.WHITEBALANCE_MANUAL, |
There was a problem hiding this comment.
For reviewers:
Deprecated in androidx
Ref : https://developer.android.com/reference/kotlin/androidx/exifinterface/media/ExifInterface#WHITEBALANCE_MANUAL()
misaochan
approved these changes
Dec 9, 2024
sivaraam
pushed a commit
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android.media.ExifInterface;toandroidx.exifinterface.media.ExifInterface#5994