Always show upload icon

[parneet-guraya]

Fixes #5847

Based on @bxy379987 's PR #5901 :

PR makes uploadIcon visibility to show at all times.

[parneet-guraya]

@nicolas-raoul

from comment in original PR

Testing this branch, the icon is always visible but numbers are flickering and often invisible:
screen-20241115-173301.mp4

apps-android-commons/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

Line 535 in c175a4e

setUploadIconCount();

This method triggers the fetching & observing (using observable type livedata) of pending & failed uploads. But in either of the case when the fetching happens new instance of livedata is created and observed. Since all this happens in onResume() anything that triggers it (very commons scenarios is navigation to some place else, going to home screen or configuration changes) will lead to new observers that are doing the same thing i.e updating the visibility.

Basically multiple observers are trying to update the visibility since it's not necessary that all observers will get fired at same time, this lead to flickers as you complain. On top of this when pending count changes.

BTW I don't have this many pictures (uploadable) that can give me enough time to reproduce this while they're uploading. Maybe I can try getting some solid color images? Anyways I think this is a separate issue because we changed the visibility of upload icon not the count indicators. It's just that the problem have been hiding when it wasn't visible.

[nicolas-raoul]

I don't have this many pictures

You can use the beta flavor/server for this. The beta server accepts any test picture. :-)

Whenever you need encyclopedia-worthy pictures to upload to the production server (some issues are applicable only to the production server), please ask me and I can send you a hundred or so.

[nicolas-raoul]

Working great, thanks!